Add Branding Manager, add GitHub token#1289
Merged
Merged
Conversation
ks129
requested review from
MrHemlock and
jb3
and removed request for
a team
ghost
added
the
ks129
added
the
a: backend
Xithrius
approved these changes
Dec 31, 2020
Contributor
There was a problem hiding this comment.
You've done an absolutely great job of seamlessly transferring this feature from sir-lancebot to this bot.
I've reviewed this as thoroughly as I could and I didn't find any conflicts or dead functions/methods/classes.
After the conflicts are resolved, this PR should be good to go.
Member
|
Could you please resolve these conflicts @ks129? |
Contributor
Author
|
@Den4200 Conflicts resolved. |
MarkKoz
requested changes
Jan 5, 2021
Contributor
MarkKoz
left a comment
MarkKoz
left a comment
There was a problem hiding this comment.
I'd like to see seasons.py, branding.py, and the feature-specific constants all under one sub-package.
Den4200
previously requested changes
Jan 6, 2021
Co-authored-by: Dennis Pham <dennis@dennispham.me>
To keep everything at one place, moved all branding manager special things to one module.
MarkKoz
requested changes
Jan 13, 2021
Contributor
MarkKoz
left a comment
MarkKoz
left a comment
There was a problem hiding this comment.
I think it's a little overkill to define an error module for a single error, but it's honestly fine so don't worry about changing it.
MarkKoz
approved these changes
Jan 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branding manager move got approved in #dev-contrib
Added GH token from env variableBranding managerGITHUB_TOKEN.and PEPsuse this now.Moved branding manager from SeasonalBot (Cobra) to Python.